[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async |
Date: |
Mon, 5 Mar 2012 14:56:46 -0300 |
On Mon, 05 Mar 2012 19:29:14 +0200
Avi Kivity <address@hidden> wrote:
> On 03/05/2012 07:27 PM, Anthony Liguori wrote:
> > On 03/05/2012 11:20 AM, Avi Kivity wrote:
> >> On 03/05/2012 04:33 PM, Anthony Liguori wrote:
> >>>
> >>>
> >>> async in QEMU doesn't mean "generate a QMP event when you're done".
> >>> It should mean execute this closure when you finish (function pointer
> >>> + opaque).
> >>>
> >>> The QMP event should be dispatched from the closure such that the
> >>> screendump code doesn't have to have a direct dependency on QMP.
> >>>
> >>
> >> What about using the parallel execution facility of qmp? It's silly to
> >> duplicate every command X with X-async and X-COMPLETED.
> >
> > We need to switch over to QAPI to get there.
>
> Just an implementation detail, yes? No spec/protocol changes?
We haven't discussed it yet how to do async commands in detail, so it may or
may not have protocol changes.
I have a simple proposal in mind, but haven't submitted it yet.
> > We're pretty close to being there. Luiz, about how long do you
> > think before we get there?
>
> It's a pity to add new commands along the way.
We decided not to block useful features because of the long time that's
taking to do async support properly.
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, (continued)
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Anthony Liguori, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/05
- [Qemu-devel] [PATCH v3 0/3] screendump async command, Alon Levy, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Avi Kivity, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Anthony Liguori, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Avi Kivity, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Anthony Liguori, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Avi Kivity, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Anthony Liguori, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Luiz Capitulino, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Avi Kivity, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Luiz Capitulino, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Gerd Hoffmann, 2012/03/06
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/06