[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 12/13] osdep: Remove local definition of macro offse
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 12/13] osdep: Remove local definition of macro offsetof |
Date: |
Wed, 7 Mar 2012 12:44:46 +0000 |
From: Stefan Weil <address@hidden>
The macro offsetof is defined in stddef.h. It is conforming to
the standards C89, C99 and POSIX.1-2001 (see man page), so it
is a sufficiently old standard.
Therefore chances are very high that QEMU never needs a local
definition of this macro.
osdep.h already includes stddef.h, so this patch simply removes
the unneeded code from the files configure and osdep.h.
If we ever need the local definition again, it should be added
to compiler.h (the macro is usually provided with the compiler,
it is not OS specific).
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
configure | 14 --------------
osdep.h | 3 ---
2 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/configure b/configure
index e19b6e3..ed3d907 100755
--- a/configure
+++ b/configure
@@ -2524,17 +2524,6 @@ if test "$darwin" != "yes" -a "$mingw32" != "yes" -a
"$solaris" != yes -a \
fi
##########################################
-# check if the compiler defines offsetof
-
-need_offsetof=yes
-cat > $TMPC << EOF
-#include <stddef.h>
-int main(void) { struct s { int f; }; return offsetof(struct s, f); }
-EOF
-if compile_prog "" "" ; then
- need_offsetof=no
-fi
-
# spice probe
if test "$spice" != "no" ; then
cat > $TMPC << EOF
@@ -3199,9 +3188,6 @@ fi
if test "$tcg_interpreter" = "yes" ; then
echo "CONFIG_TCG_INTERPRETER=y" >> $config_host_mak
fi
-if test "$need_offsetof" = "yes" ; then
- echo "CONFIG_NEED_OFFSETOF=y" >> $config_host_mak
-fi
if test "$fdatasync" = "yes" ; then
echo "CONFIG_FDATASYNC=y" >> $config_host_mak
fi
diff --git a/osdep.h b/osdep.h
index 432b91e..0350383 100644
--- a/osdep.h
+++ b/osdep.h
@@ -26,9 +26,6 @@
#define unlikely(x) __builtin_expect(!!(x), 0)
#endif
-#ifdef CONFIG_NEED_OFFSETOF
-#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *) 0)->MEMBER)
-#endif
#ifndef container_of
#define container_of(ptr, type, member) ({ \
const typeof(((type *) 0)->member) *__mptr = (ptr); \
--
1.7.9.1
- [Qemu-devel] [PATCH 05/13] block/vmdk: Fix warning from splint (comparision of unsigned value), (continued)
- [Qemu-devel] [PATCH 05/13] block/vmdk: Fix warning from splint (comparision of unsigned value), Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 04/13] qmp: Fix spelling fourty -> forty, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 01/13] ppc: Add missing 'static' to spin_rw_ops, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 09/13] vnc: Add break statement, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 13/13] configure: Quote the configure args printed in config.log, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 10/13] Spelling fixes in comments (it's -> its), Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 06/13] Fix sign of sscanf format specifiers, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 11/13] libcacard: Spelling and grammar fixes in documentation, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 08/13] libcacard: Use format specifier %u instead of %d for unsigned values, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 12/13] osdep: Remove local definition of macro offsetof,
Stefan Hajnoczi <=