[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag
From: |
Roland McGrath |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag |
Date: |
Wed, 7 Mar 2012 13:41:04 -0800 (PST) |
A few of the vDSO VM_ALWAYSDUMP cases have a comment about the core dump.
(It looks like they were all copied from my original comment in
arch/x86/vdso/vdso32-setup.c.) So those should be removed where they are.
(You removed some of them, but not all.) You should put that comment into
always_dump_vma.
get_gate_vma is always defined quite trivially, and is also the most
logically obvious case, so I would test it first.
It sounds like the Tile special case is unnecessary, so just
arch_vma_name(vma) != NULL is an adequate test. Please give it
a clear comment about why that test makes sense, i.e. because all
extant uses are for a vDSO or something similar.
Thanks,
Roland
- [Qemu-devel] [PATCH 0/2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_DONTDUMP, Jason Baron, 2012/03/07
- Re: [Qemu-devel] [PATCH 0/2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_DONTDUMP, Andrew Morton, 2012/03/07
- [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag, Jason Baron, 2012/03/07
- Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag, Roland McGrath, 2012/03/07
- Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag, Jason Baron, 2012/03/07
- Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag, Roland McGrath, 2012/03/07
- Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag, Jason Baron, 2012/03/07
- Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag,
Roland McGrath <=
- Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag, Chris Metcalf, 2012/03/07
- Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag, Jason Baron, 2012/03/07
[Qemu-devel] [PATCH 2/2] core dump: add a new VM_DONTDUMP flag, Jason Baron, 2012/03/07