[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd |
Date: |
Fri, 09 Mar 2012 13:46:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/08/12 01:41, David Gibson wrote:
> From: Benjamin Herrenschmidt <address@hidden>
> - assert(s->csw.sig == 0x53425355);
> + assert(s->csw.sig == cpu_to_le32(0x53425355));
Correct but incomplete. residue is sent in host endian instead of
little endian too. It is zero most of the time though, so it easily
goes unnoticed.
Can you try the attached patch instead?
cheers,
Gerd
0001-usb-storage-fix-byteorder-issues.patch
Description: Text document
[Qemu-devel] [PATCH 3/4] kvm: Fix dirty tracking with large kernel page size, David Gibson, 2012/03/07
[Qemu-devel] [PATCH 4/4] pci: Factor out bounds checking on config space accesses, David Gibson, 2012/03/07