Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'

[Kevin Wolf]

Am 09.03.2012 14:26, schrieb Andreas Färber:
> Am 09.03.2012 13:46, schrieb Kevin Wolf:
>> Runs the full qemu-iotests suite for various image formats.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> ---
>>  tests/Makefile       |    6 +++++-
>>  tests/check-block.sh |   21 +++++++++++++++++++++
>>  2 files changed, 26 insertions(+), 1 deletions(-)
>>  create mode 100755 tests/check-block.sh
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 571ad42..6b4f4aa 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -47,6 +47,10 @@ test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) 
>> $(qapi-obj-y) $(tools-ob
>>  
>>  $(SRC_PATH)/tests/qemu-iotests-quick.sh: qemu-img qemu-io
>>  
>> -.PHONY: check
>> +
>> +.PHONY: check check-block
> 
> Minor nit: Since you already add a second empty line before .PHONY, care
> to also add one before check: analog to check-block:?

Sure.

>>  check: $(CHECKS)
>>      $(call quiet-command, gtester $(CHECKS), "  CHECK")
>> +
>> +check-block:
>> +    $(call quiet-command, $(SRC_PATH)/tests/check-block.sh , "  CHECK")
> 
> Please use $(SHELL) here.

Ok, I can do that. But what's the difference?

Kevin