[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loa
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading |
Date: |
Fri, 9 Mar 2012 19:22:43 +0100 |
On 09.03.2012, at 17:40, Mark Langsdorf wrote:
> On 03/09/2012 10:13 AM, Peter Maydell wrote:
>> On 9 March 2012 15:57, Mark Langsdorf <address@hidden> wrote:
>>> Since the ram_size field of arm_boot_info is only an int, don't set
>>> that field to more than INT_MAX. Signed vs unsigned comparison
>>> overruns are possible otherwise.
>>
>> Can't we just make arm_boot_info.ram_size a uint32_t (propagating through
>> signedness fixes as required) ?
>>
>> Actually it should probably be a target_phys_addr_t, thinking ahead
>> to adding LPAE support.
>
> It really should be a size_t, per the upthread discussion with Andreas
> Faerber.
No, Andreas is wrong. Host data types have nothing to do in target ram fiddling
code. The type you're searching for is "the size of physical address space the
guest can handle" and that's target_phys_addr_t. Period.
Alex
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, (continued)
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Andreas Färber, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Andreas Färber, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Markus Armbruster, 2012/03/09
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Mark Langsdorf, 2012/03/09
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Markus Armbruster, 2012/03/09
[Qemu-devel] [PATCH v2] use an unsigned long for the max_sz parameter in load_image_targphys, Mark Langsdorf, 2012/03/09
[Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading, Mark Langsdorf, 2012/03/09
[Qemu-devel] [PATCH v3] use an uint64_t for the max_sz parameter in load_image_targphys, Mark Langsdorf, 2012/03/12
Re: [Qemu-devel] [PATCH v3] use an uint64_t for the max_sz parameter in load_image_targphys, Alexander Graf, 2012/03/12