Re: [Qemu-devel] [PATCH 2/2] memory: print aliased IO ranges in info mtree

[Avi Kivity]

On 03/11/2012 01:00 PM, Blue Swirl wrote:
> Print also I/O ports behind bridges and other aliases.
>
> Signed-off-by: Blue Swirl <address@hidden>
> ---
>  memory.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index 4c3dc49..0201392 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1639,7 +1639,20 @@ void mtree_info(fprintf_function mon_printf, void *f)
>      if (address_space_io.root &&
>          !QTAILQ_EMPTY(&address_space_io.root->subregions)) {
>          QTAILQ_INIT(&ml_head);
> +
>          mon_printf(f, "I/O\n");
>          mtree_print_mr(mon_printf, f, address_space_io.root, 0, 0, &ml_head);
> +
> +        /* print aliased I/O regions */
> +        QTAILQ_FOREACH(ml, &ml_head, queue) {
> +            if (!ml->printed) {
> +                mon_printf(f, "%s\n", ml->mr->name);
> +                mtree_print_mr(mon_printf, f, ml->mr, 0, 0, &ml_head);
> +            }
> +        }
> +    }
> +
> +    QTAILQ_FOREACH_SAFE(ml, &ml_head, queue, ml2) {
> +        g_free(ml);
>      }
>  }

This is just duplication.  A little refactoring would eliminate it.

Also, we might have an alias from the memory address space and an alias
from the I/O address space pointing into the same region.  So maybe
alias printing should be consolidated for all address spaces.

-- 
error compiling committee.c: too many arguments to function