[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH (trivial)] no need to use bdrv_pread() in format gue
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PATCH (trivial)] no need to use bdrv_pread() in format guessing code when we can use bdrv_read() directly |
Date: |
Tue, 13 Mar 2012 20:22:51 +0400 |
[Sorry - sent the wrong patch, should have been
BDRV_SECTOR_SIZE, not BDRV_BLOCK_SIZE....]
block.c:find_image_format() calls bdrv_pread() to read first 2048
bytes from the device to guess its format. This function can use
bdrv_read() directly since the the read is done on sector boundary.
Signed-off-by: Michael Tokarev <address@hidden>
---
block.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index b88ee90..b3af1f6 100644
--- a/block.c
+++ b/block.c
@@ -469,7 +469,7 @@ static int find_image_format(const char *filename,
BlockDriver **pdrv)
return ret;
}
- ret = bdrv_pread(bs, 0, buf, sizeof(buf));
+ ret = bdrv_read(bs, 0, buf, sizeof(buf) / BDRV_SECTOR_SIZE);
bdrv_delete(bs);
if (ret < 0) {
*pdrv = NULL;
--
1.7.9.1