[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 8/9] net: split hostname and service by last
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v3 8/9] net: split hostname and service by last colon |
Date: |
Tue, 13 Mar 2012 14:34:16 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 07, 2012 at 06:48:48AM +0800, Amos Kong wrote:
> IPv6 address contains colons, parse will be wrong.
>
> [2312::8274]:5200
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> net.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net.c b/net.c
> index 2518e5f..d6ce1fa 100644
> --- a/net.c
> +++ b/net.c
> @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char
> **pp, int sep)
> const char *p, *p1;
> int len;
> p = *pp;
> - p1 = strchr(p, sep);
> + p1 = strrchr(p, sep);
Some callers expect get_str_sep() to split from the front,
net/slirp.c:net_slirp_hostfwd_remove() for example.
Would add a seperate helper, or replace it with a wrapper around a more
generic implementation.
> if (!p1)
> return -1;
> len = p1 - p;
>
>
- [Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start(), (continued)
- [Qemu-devel] [PATCH v3 4/9] net: use tcp_client_start for tcp client creation, Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 6/9] net: use getaddrinfo() in tcp_start_common, Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 7/9] net: introduce parse_host_port_info(), Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 5/9] net: refector tcp_*_start functions, Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 8/9] net: split hostname and service by last colon, Amos Kong, 2012/03/06
- Re: [Qemu-devel] [PATCH v3 8/9] net: split hostname and service by last colon,
Michael Roth <=
- [Qemu-devel] [PATCH v3 9/9] net: support to include ipv6 address by brackets, Amos Kong, 2012/03/06