[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference |
|
Date: |
Wed, 14 Mar 2012 15:30:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 |
Am 14.03.2012 08:59, schrieb Markus Armbruster:
> Andreas Färber <address@hidden> writes:
>
>> Am 13.03.2012 19:32, schrieb Mark Langsdorf:
>>> From: Joshua Housh <address@hidden>
>>>
>>> Make sure a BusInfo exists before trying to dereference it.
>>
>> What's the use case that breaks?
>
> Valid question.
>
> Every qdev has / used to have a parent bus, and every bus info. If
> that's not true anymore, it would be nice to have the commit message
> point to the commit that broke it.
My guess would be a direct usage of QOM TYPE_DEVICE, something I've
tried to avoid in the CPU series so far... there's likely more things
that need changing then.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg