Re: [Qemu-devel] [PATCH RFC v4 08/20] target-arm: Store cp15 c0_c1 and c0_c2 in ARMCPUClass

[Paul Brook]

> For now set them in the reset function.

> +    /* TODO Move these into arm_cpu_initfn() once no longer zeroed above.*/
> +    memcpy(env->cp15.c0_c1, klass->cp15.c0_c1, 8 * sizeof(uint32_t));
> +    memcpy(env->cp15.c0_c2, klass->cp15.c0_c2, 8 * sizeof(uint32_t)); +

Why bother copying them into the CPU state?  These are readonly, so anything 
that needs them should be able to use the value straight from the class 
definitions.

Paul