[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu
From: |
HATAYAMA Daisuke |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file |
Date: |
Fri, 16 Mar 2012 10:48:36 +0900 ( ) |
From: Wen Congyang <address@hidden>
Subject: [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core
file
Date: Wed, 14 Mar 2012 10:09:26 +0800
> + memset(note, 0, note_size);
> + if (type == 0) {
> + note32 = note;
> + note32->n_namesz = cpu_to_le32(name_size);
> + note32->n_descsz = cpu_to_le32(descsz);
> + note32->n_type = 0;
> + } else {
> + note64 = note;
> + note64->n_namesz = cpu_to_le32(name_size);
> + note64->n_descsz = cpu_to_le32(descsz);
> + note64->n_type = 0;
> + }
Why not give new type for this note information an explicit name?
Like NT_QEMUCPUSTATE? There might be another type in the future. This
way there's also a merit that we can know all the existing notes
relevant to qemu dump by looking at the names in a header file.
Thanks.
HATAYAMA, Daisuke
- [Qemu-devel] [RFC][PATCH 04/14 v9] Add API to check whether paging mode is enabled, (continued)
- [Qemu-devel] [RFC][PATCH 04/14 v9] Add API to check whether paging mode is enabled, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 06/14 v9] Add API to get memory mapping without do paging, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 07/14 v9] target-i386: Add API to write elf notes to core file, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file, Wen Congyang, 2012/03/13
- Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file,
HATAYAMA Daisuke <=
- [Qemu-devel] [RFC][PATCH 09/14 v9] target-i386: add API to get dump info, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 10/14 v9] make gdb_id() generally avialable, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/13