Re: [Qemu-devel] [PATCH] softfloat: fix for C99

[Andreas Färber]

Am 09.02.2012 17:38, schrieb Avi Kivity:
> On 02/09/2012 06:20 PM, Andreas Färber wrote:
>> Am 27.12.2011 17:15, schrieb Andreas Färber:
>>> Am 27.12.2011 16:11, schrieb Avi Kivity:
>>>> C99 appears to consider compound literals as non-constants, and complains
>>>> when they are used in static initializers.  Switch to ordinary initializer
>>>> syntax.
>>>>
>>
>> Reported-by: Andreas Färber <address@hidden>
>>
>>>> Signed-off-by: Avi Kivity <address@hidden>
>>>
>>> Acked-by: Andreas Färber <address@hidden>
>>>
>>> For the record, tested with --extra-cflags=-std=gnu99.
>>>
>>>> diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
>>>> index c5e2dab..4902450 100644
>>>> --- a/fpu/softfloat-specialize.h
>>>> +++ b/fpu/softfloat-specialize.h
>>>> @@ -89,8 +89,8 @@ const float64 float64_default_nan = const_float64(LIT64( 
>>>> 0xFFF8000000000000 ));
>>>>  #define floatx80_default_nan_low  LIT64( 0xC000000000000000 )
>>>>  #endif
>>>>  
>>>> -const floatx80 floatx80_default_nan = 
>>>> make_floatx80(floatx80_default_nan_high,
>>>> -                                                    
>>>> floatx80_default_nan_low);
>>>> +const floatx80 floatx80_default_nan
>>>> +    = make_floatx80_init(floatx80_default_nan_high, 
>>>> floatx80_default_nan_low);
>>>
>>> Calling it init_floatx80 would avoid the line break, but I'm okay with
>>> it either way.
>>
>> Ping! Avi, you didn't indicate whether you were going to simplify this
>> patch or whether you're waiting for someone to apply it as is?
>>
> 
> Actually I forgot all about it.  If everyone's okay with it as is I'd
> like it to be applied, otherwise I'll respin.  Copying some maintainers
> completely at random.

Ping?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg