[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: add the support to drain throttled reque
From: |
Zhi Yong Wu |
Subject: |
Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests |
Date: |
Tue, 20 Mar 2012 17:40:00 +0800 |
HI, Kevin,
We hope that I/O throttling can be shipped without known issue in QEMU
1.1, so if you are available, can you give this patch some love?
On Tue, Mar 13, 2012 at 9:53 AM, <address@hidden> wrote:
> From: Zhi Yong Wu <address@hidden>
>
> Signed-off-by: Zhi Yong Wu <address@hidden>
> [ Iterate until all block devices have processed all requests,
> add comments. - Paolo ]
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block.c | 24 ++++++++++++++++++++++--
> 1 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/block.c b/block.c
> index 52ffe14..52dabd0 100644
> --- a/block.c
> +++ b/block.c
> @@ -858,12 +858,32 @@ void bdrv_close_all(void)
> *
> * This function does not flush data to disk, use bdrv_flush_all() for that
> * after calling this function.
> - */
> + *
> + * Note that completion of an asynchronous I/O operation can trigger any
> + * number of other I/O operations on other devices---for example a coroutine
> + * can be arbitrarily complex and a constant flow of I/O to multiple devices
> + * can come until the coroutine is complete. Because of this, it is not
> + * possible to drain a single device's I/O queue.
> +*/
> void bdrv_drain_all(void)
> {
> BlockDriverState *bs;
> + bool busy;
>
> - qemu_aio_flush();
> + do {
> + busy = false;
> + qemu_aio_flush();
> +
> + /* FIXME: We do not have timer support here, so this is effectively
> + * a busy wait.
> + */
> + QTAILQ_FOREACH(bs, &bdrv_states, list) {
> + if (!qemu_co_queue_empty(&bs->throttled_reqs)) {
> + qemu_co_queue_restart_all(&bs->throttled_reqs);
> + busy = true;
> + }
> + }
> + } while (busy);
>
> /* If requests are still pending there is a bug somewhere */
> QTAILQ_FOREACH(bs, &bdrv_states, list) {
> --
> 1.7.6
>
--
Regards,
Zhi Yong Wu
- [Qemu-devel] [PATCH] block: add the support to drain throttled requests, zwu . kernel, 2012/03/12
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests,
Zhi Yong Wu <=
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Paolo Bonzini, 2012/03/20
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Kevin Wolf, 2012/03/20
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Stefan Hajnoczi, 2012/03/20
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Chris Webb, 2012/03/22
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Stefan Hajnoczi, 2012/03/23
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Chris Webb, 2012/03/23
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Stefan Hajnoczi, 2012/03/23
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Richard Davies, 2012/03/23
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Stefan Hajnoczi, 2012/03/23
- Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests, Stefan Hajnoczi, 2012/03/23