Re: [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code

[Michael S. Tsirkin]

On Wed, Mar 21, 2012 at 01:32:44PM +0100, Andreas Färber wrote:
> Hi,
> 
> Am 21.03.2012 06:26, schrieb Alexey Korolev:
> >> Hi,
> >>
> >> There is a typo in i440FX init code. This is causing problems when
> >> somebody wants to access 64bit PCI range.
> >>
> >>
> >> Signed-off-by: Alexey Korolev <address@hidden>
> >> ---
> >>
> >>  hw/piix_pci.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> >> index 3ed3d90..aab8188 100644
> >> --- a/hw/piix_pci.c
> >> +++ b/hw/piix_pci.c
> >> @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, 
> >> int *piix3_devfn,
> >>      b = i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, isa_bus, 
> >> pic,
> >>                             address_space_mem, address_space_io, ram_size,
> >>                             pci_hole_start, pci_hole_size,
> >> -                           pci_hole64_size, pci_hole64_size,
> >> +                           pci_hole64_start, pci_hole64_size,
> >>                             pci_memory, ram_memory);
> >>      return b;
> >>  }
> >>
> >>
> >>
> > Hi there,
> > 
> > Any chance that someone could have a look and commit this?
> 
> A patch should never start with "Hi,", it should have a commit message
> that can be applied unmodified to git, describing what area it touches,
> what it changes and why. So, the the subject should start with, e.g.,
> "i440fx: Fix start of 64-bit hole" and go on to explain where exactly
> that is and what it affects (does this resolve some guest-visible bug?
> when was it introduced? i.e., does it need to be backported?). Repeating
> "typo" again and again is not helpful to understand the impact of a
> commit when bisecting later on without seeing the code.
> 
> You forgot to cc the PCI maintainer.
> 
> Andreas

Yes I'd like to see an explanation on how to trigger a bug too.
OTOH the fix is clearly right, and it's not submitter's
work to dig through history to find where was the bug
added, that is too much to ask IMO.

> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg