[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 4/7] qed: add bdrv_invalidate_cache to be cal
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V2 4/7] qed: add bdrv_invalidate_cache to be called after incoming live migration |
Date: |
Thu, 22 Mar 2012 15:30:12 +0000 |
On Thu, Mar 22, 2012 at 2:17 PM, Paolo Bonzini <address@hidden> wrote:
> Il 22/03/2012 15:15, Benoît Canet ha scritto:
>>
>> I added this flag after seeing the following code in in bdrv_open_common.
>>
>> /*
>> * Clear flags that are internal to the block layer before opening the
>> * image.
>> */
>> open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
>>
>> This lead me to believe that bs->open_flags != open_flags.
>
> Correct, see the first two patches in the series at
> http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03467.html
We mangle the flags but I guess what I'm asking is, does it even
matter? Those two bits don't affect qed or qcow2 .bdrv_open(). If
possible, I think we should use bs->open_flags.
Stefan
- [Qemu-devel] [PATCH V2 2/7] block: add a function to clear incoming live migration flags, (continued)
- [Qemu-devel] [PATCH V2 2/7] block: add a function to clear incoming live migration flags, Benoît Canet, 2012/03/21
- [Qemu-devel] [PATCH V2 1/7] block: Add new BDRV_O_INCOMING flag to notice incoming live migration, Benoît Canet, 2012/03/21
- [Qemu-devel] [PATCH V2 7/7] qed: remove incoming live migration blocker, Benoît Canet, 2012/03/21
- [Qemu-devel] [PATCH V2 3/7] blockdev: open images with BDRV_O_INCOMING on incoming live migration, Benoît Canet, 2012/03/21
- [Qemu-devel] [PATCH V2 6/7] qed: honor BDRV_O_INCOMING for incoming live migration, Benoît Canet, 2012/03/21
- [Qemu-devel] [PATCH V2 5/7] migration: clear BDRV_O_INCOMING flags on end of incoming live migration, Benoît Canet, 2012/03/21
- [Qemu-devel] [PATCH V2 4/7] qed: add bdrv_invalidate_cache to be called after incoming live migration, Benoît Canet, 2012/03/21