Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

[Anthony Liguori]

On 03/26/2012 10:54 AM, Isaku Yamahata wrote:
> On Mon, Mar 26, 2012 at 02:20:24PM +0200, Jan Kiszka wrote:
> > I'm also sure we will have to refactor the merge significantly again for
> > the introduction of additional chipsets and PC boards. But unless those
> > requirements can already be specified (Isaku?), that might be unavoidable.
>
> Agreed. At least I'd like pam/smram stuff decoupled from piix.

s/piix/i440fx/

PAM/SRAM has nothing do to with the piix.  Part of the problem with the current 
layout is that the distinction between i440fx and piix is not clear.  The piix 
is just a SuperIO chip (and southbridge).

I think the better approach is to have a PCNorthBridge base-class that contains 
functionality like PAM/SRAM that both I440FX and Q35 inherit from.

Obviously, without getting the I440FX/PIIX3 modeling in shape, we can't look 
reasonable at how to share code.

Regards,

Anthony Liguori

> It is difficult to understand why patches of 5, 6 are needed without further
> patches because they don't show how the code will look like eventually.
> Anyway I expect some sort of refactor again and am waiting for QOM related
> stuff stabilizing.
>
> thanks,