[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/9] net: introduce one net host device class
From: |
Zhi Yong Wu |
Subject: |
Re: [Qemu-devel] [RFC 2/9] net: introduce one net host device class |
Date: |
Tue, 27 Mar 2012 17:13:03 +0800 |
On Tue, Mar 27, 2012 at 4:30 PM, Paolo Bonzini <address@hidden> wrote:
> Il 26/03/2012 07:40, address@hidden ha scritto:
>> + /*< public >*/
>> + QemuOpts *opts;
>> + Monitor *mon;
>> + const char *name;
>> + NetClientState *peer;
>> +};
>
> The QemuOpts should not be part of the struct. You need to store them
> into properties at initialization time, and forget them afterwards.
This should be done in your QemuOpts QOM feature, right?:)
>
> All the infrastructure to do this is already in qdev-properties.c.
>
> Paolo
--
Regards,
Zhi Yong Wu
- [Qemu-devel] [RFC 0/9] QOM: qomify -netdev, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model, zwu . kernel, 2012/03/26
- [Qemu-devel] [PATCH] net: qomify -netdev, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 4/9] net: adjust nic init API, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 3/9] net: adjust net common part for qomify -netdev, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 2/9] net: introduce one net host device class, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 6/9] net: qomify -netdev user, zwu . kernel, 2012/03/26
- [Qemu-devel] [PATCH] net: qomify -netdev, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 7/9] net: qomify -netdev socket, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 8/9] net: qomify -netdev vde, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 5/9] net: adjust dump init API, zwu . kernel, 2012/03/26
- [Qemu-devel] [RFC 9/9] net: qomify -netdev tap & -netdev bridge, zwu . kernel, 2012/03/26
- Re: [Qemu-devel] [RFC 0/9] QOM: qomify -netdev, Stefan Hajnoczi, 2012/03/26