qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] spice_info: add mouse_mode


From: Alon Levy
Subject: Re: [Qemu-devel] [PATCH v3] spice_info: add mouse_mode
Date: Fri, 30 Mar 2012 22:25:25 +0300
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Mar 30, 2012 at 10:12:56AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > +# @SpiceQueryMouseMode
> > +#
> > +# An enumation of Spice mouse states.
> > +#
> > +# @client: Mouse cursor position is determined by the client.
> > +#
> > +# @server: Mouse cursor position is determined by the server.
> > +#
> > +# @unknown: No information is available about mouse mode used by
> > +#           the spice server.
> > +#
> > +# Note: spice/enums.h has a SpiceMouseMode already, hence the name.
> 
> I guess it makes sense then to just add "unknown" to the existing
> SpiceMouseMode and reuse it ...

But then you don't get the nifty autogenerated lookup table, although I
agree having two enums is bound to cause confusion somehow. I could just
code a lookup table for the hmp.

> 
> cheers,
>   Gerd
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]