Re: [Qemu-devel] [PATCH 2/9] Fix checking for compiler flag support

[Stefan Weil]

Am 02.04.2012 12:50, schrieb Daniel P. Berrange:
> From: "Daniel P. Berrange" <address@hidden>
>
> Some warning flags have dependancies, eg -Wformat-security cannot
> be enabled if -Wformat is not already enabled. The compiler
> flag checking code was checking each flag in isolation so several
> were not getting enabled. The fix is to supply all previously
> confirmed flags when checking a flag
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> configure | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)

This patch is not needed, because the current test adds
the supported flags to QEMU_CFLAGS which is used in compile_prog,
so it does exactly the same thing which you try to achieve.

For flags which have dependencies, the order is important, so
a comment for such cases would be good to avoid accidental
reordering (see your previous patch 1/9).

Regards,
Stefan W.