[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/25] qdev: remove qdev_prop_set_defaults
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 08/25] qdev: remove qdev_prop_set_defaults |
Date: |
Tue, 03 Apr 2012 23:43:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 03/04/2012 23:09, Anthony Liguori ha scritto:
> On 04/03/2012 06:15 AM, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini<address@hidden>
>
>
>> ---
>> hw/qdev-properties.c | 22 ----------------------
>> hw/qdev.c | 28 +++++++++++++++++++++++-----
>> hw/qdev.h | 1 -
>> 3 files changed, 23 insertions(+), 28 deletions(-)
>>
>> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
>> index bff9152..85897c7 100644
>> --- a/hw/qdev-properties.c
>> +++ b/hw/qdev-properties.c
>> @@ -1083,28 +1083,6 @@ void qdev_prop_set_ptr(DeviceState *dev, const
>> char *name, void *value)
>> *ptr = value;
>> }
>>
>> -void qdev_prop_set_defaults(DeviceState *dev, Property *props)
>> -{
>> - Object *obj = OBJECT(dev);
>> - if (!props)
>> - return;
>> - for (; props->name; props++) {
>> - Error *errp = NULL;
>> - if (props->qtype == QTYPE_NONE) {
>> - continue;
>> - }
>> - if (props->qtype == QTYPE_QBOOL) {
>> - object_property_set_bool(obj, props->defval,
>> props->name,&errp);
>> - } else if (props->info->enum_table) {
>> - object_property_set_str(obj,
>> props->info->enum_table[props->defval],
>> - props->name,&errp);
>> - } else if (props->qtype == QTYPE_QINT) {
>> - object_property_set_int(obj, props->defval,
>> props->name,&errp);
>> - }
>> - assert_no_error(errp);
>> - }
>> -}
>> -
>> static QTAILQ_HEAD(, GlobalProperty) global_props =
>> QTAILQ_HEAD_INITIALIZER(global_props);
>>
>> static void qdev_prop_register_global(GlobalProperty *prop)
>> diff --git a/hw/qdev.c b/hw/qdev.c
>> index bb6c1aa..4ac5616 100644
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -90,7 +90,6 @@ void qdev_set_parent_bus(DeviceState *dev, BusState
>> *bus)
>> qdev_property_add_legacy(dev, prop, NULL);
>> qdev_property_add_static(dev, prop, NULL);
>> }
>> - qdev_prop_set_defaults(dev, dev->parent_bus->info->props);
>
> Does this break bisectability?
Hmm, here it does. It must be moved later.
Paolo
- Re: [Qemu-devel] [PATCH 05/25] qom: push type up to Object, (continued)
- [Qemu-devel] [PATCH 06/25] qdev: fix -device foo,?, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 08/25] qdev: remove qdev_prop_set_defaults, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 09/25] qdev: move bus properties to a separate global, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 10/25] qdev: do not propagate properties to subclasses, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 11/25] qdev: pick global properties from superclasses, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 12/25] qdev: factor setting of global properties, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 13/25] qdev: replace bus properties with superclass properties, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 14/25] qapi: add Visitor interfaces for uint*_t and int*_t, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 15/25] qdev: use int32_t container for devfn property, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 17/25] qdev: remove PropertyInfo range checking, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 19/25] qom: push state up to Object, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 23/25] qom: add realized property, Paolo Bonzini, 2012/04/03