Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

[Jan Kiszka]

On 2012-04-04 17:38, Jan Kiszka wrote:
> On 2012-04-04 17:29, Paolo Bonzini wrote:
>> Il 04/04/2012 17:24, Jan Kiszka ha scritto:
>>>>> For patches 3 and 4, I'd rather use an EventNotifier...
>>> ...which still lacks support for non-eventfd systems. Hmm, I guess it's
>>> time to consolidate both.
>>
>> Perhaps you can take the relevant patches out of the thread-blocks
>> branch at git://github.com/pbonzini/qemu.git?  The iothread eventfd
>> could also use an EventNotifier.
> 
> Current EventNotifier code applies EFD_SEMAPHORE, which is not what we
> want for Posix AIO (otherwise we could just stick with the pipe). I
> cannot match the reasoning for EFD_SEM in event_notifier.c with the man
> page, need to dig deeper.

Err, non-sense, comment and code diverged and confused my eyes...

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux