Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

[Paolo Bonzini]

----- Messaggio originale -----
> Da: "Blue Swirl" <address@hidden>
> A: "Paolo Bonzini" <address@hidden>
> Cc: address@hidden, address@hidden
> Inviato: Mercoledì, 4 aprile 2012 22:44:12
> Oggetto: Re: [Qemu-devel] [PATCH 5/6] main-loop: replace 
> WaitForMultipleObjects with g_poll
>
> On Tue, Mar 20, 2012 at 09:49, Paolo Bonzini <address@hidden>
> wrote:
> > On w32, glib implements g_poll using WaitForMultipleObjects
> > or MsgWaitForMultipleObjects.  This means that we can simplify
> > our code by switching to g_poll, and at the same time prepare for
> > adding back glib sources.
>
> Unfortunately g_poll does not seem to be available in glib-2.0:
>   CC    main-loop.o
> /src/qemu/main-loop.c: In function 'os_host_main_loop_wait':
> /src/qemu/main-loop.c:438: warning: implicit declaration of function
> 'g_poll'
> /src/qemu/main-loop.c:438: warning: nested extern declaration of
> 'g_poll'
>   LINK  qemu-img.exe
> main-loop.o: In function `os_host_main_loop_wait':
> /src/qemu/main-loop.c:438: undefined reference to `_g_poll'

Supporting old glibs makes sense on Linux where we have enterprise
distributions to support, but not on Windows where glib is going to
be bundled with the executable anyway.  If anyone is interested they
can simply lift g_poll from glib and put it somewhere in the QEMU
sources.  I don't care enough; until we decide what to do, applying
patches 2-4 will fix some of the breakage.

(Also, the lowest common denominator for Linux would be 2.12, not 2.0.
Win32 g_poll was not available until 2.20).

Paolo