Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

[Andreas Färber]

Am 03.04.2012 15:03, schrieb Paolo Bonzini:
> Il 03/04/2012 14:11, Andreas Färber ha scritto:
>> Since this patch is clearly an extended version of my realize patch
>> http://patchwork.ozlabs.org/patch/148752/, it should carry my SoB, as
>> reminded last night. If you don't want my SoB on the parts I didn't do -
>> namely unrealize and *_childen - then feel free to split the patch in
>> two. Simply dropping attribution in both cover letter and commit just
>> because I didn't get around yet to sending a v2 with those requests
>> addressed is not nice!
> 
> Technically it's not, because I redid it from scratch (I never even had
> time to really look at your patches beyond reading the commit message,
> and I did this part while I didn't even have network access).

That's just as lame an accuse as Fabrice's when he "redid" a patch of
rth back in CVS days. You were around on IRC on March 23rd when I
offered to aliguori to put together a patch for realize (which I am
using in my qom-cpu-sh4 series). Had you volunteered back then, I
wouldn't have invested time and we wouldn't be having this discussion.
But if there's something I hate more than political extremism, it's
having my time wasted.

I was fair to cc you and Anthony on it, to avoid clashes between those
of us working on QOM, you commented on my series, so you have read part
of it; yet you announce the day before your series that you are going to
send realize and ignore my request to not forget my SoB if you do. That
makes me think that you're deliberately trying to keep my code
contribution out of the picture there, whereas Anthony has stated in the
context of unicore32 that rewriting someone's contribution to get that
person's authorship out of the way were not acceptable.

Apart from the personal disrespect this implies here, it's also about me
wanting to prove my bosses that I don't just sit in an arm chair or
write useless crap. My patch is available under GPLv2+ allowing anyone
to freely modify and reuse that code but doing so without copyright and
authorship attribution is in violation of the license. I respect
people's contributions and am all in favor of documenting people's
effort with Reported-by, Tested-by, Reviewed-by, and I expect that
others respect mine too.

You had me write a trivial follow-up to your series, which I did now, so
you should consider living to the same standard and following up on mine.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg