[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] versatilepb: add i2c support
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] versatilepb: add i2c support |
Date: |
Thu, 5 Apr 2012 18:45:52 +0100 |
On 2 April 2012 21:17, Oskar Andero <address@hidden> wrote:
> Signed-off-by: Oskar Andero <address@hidden>
> ---
> hw/versatilepb.c | 80
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 80 insertions(+), 0 deletions(-)
This is just a cut-n-paste of the i2c device in hw/realview.c.
Instead of duplicating the code we should pull it out into
its own source file, give it a name which doesn't have 'realview'
in it (since it's the same thing in all these boards) and
then use that new device in all the boards which have it.
-- PMM