[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp: make block job command naming consistent
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qmp: make block job command naming consistent |
Date: |
Wed, 11 Apr 2012 09:40:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/11/2012 09:27 AM, Stefan Hajnoczi wrote:
> The block streaming and job commands used '_' instead of '-' for reasons
> of compatibility with libvirt, which already included support for the
> '_' naming. However, the semantics of block_job_cancel have changed and
> libvirt now needs to handle the new semantics.
>
> Since the old semantics were never in a QEMU release we can still rename
> the commands to use '-' instead of '_'. Libvirt is also happy because
> the new name can be used to distinguish QEMU binaries that support the
> latest block-job-cancel semantics from those that include a downstream
> block_job_cancel command.
>
> Therefore, let's apply the QAPI/QMP naming rules to the block streaming
> and job commands. QEMU 1.1 will be the first release with these
> commands so no upstream users can break.
>
> Note that HMP commands are left with '_' because that is the convention
> there.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qapi-schema.json | 15 ++++++++-------
> qmp-commands.hx | 6 +++---
> tests/qemu-iotests/030 | 12 ++++++------
> 3 files changed, 17 insertions(+), 16 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature