Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

[Peter Maydell]

On 5 April 2012 10:35, Wei Liu <address@hidden> wrote:
>
> --- /dev/null
> +++ b/hw/xen_apic.c
> @@ -0,0 +1,90 @@
> +/*
> + * Xen basic APIC support
> + *
> + * Copyright (c) 2012 Citrix
> + *
> + * Authors:
> + *  Wei Liu <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL version 2.
> + * See the COPYING file in the top-level directory.
> + */

Really 2-only, not 2-or-later ?

> +#include "hw/apic_internal.h"
> +#include "hw/msi.h"
> +#include "xen.h"
> +
> +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr,
> +                                  unsigned size)
> +{
> +    return -1U;
> +}

This seems a rather confusing way to write 'return 0xffffffff;'

-- PMM