|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added. |
Date: | Wed, 11 Apr 2012 21:08:47 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 11/04/2012 19:25, Anthony Liguori ha scritto: >> >> Off the top of my head: issues with v5: >> polluting global namespace, must scope names >> appropriately with vmxnet_ VMXNET_ unless they have file scope. >> Don't use names with _ followed by an upper case letter >> or that star with two underscores. Don't mix underscores and mixed case. >> Don't stick any new types in net.c/pci.c - new devices should use -device >> not -net. Global stuff like ethernet header size >> should move to central place instead of copy paste. > > I'd like to see qtest test cases for this too. I think as things stand it is a bit too much to request this. You're basically asking to write a libos. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |