Re: [Qemu-devel] [PATCH v2 2/3] target-microblaze: QOM'ify CPU reset

[Andreas Färber]

Am 12.04.2012 11:50, schrieb Edgar E. Iglesias:
> On Thu, Apr 12, 2012 at 03:25:30AM +0200, Andreas Färber wrote:
>> Am 12.04.2012 03:14, schrieb John Williams:
>>> 2012/4/12 Andreas Färber <address@hidden>:
>>>> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
>>>> index ea646fe..194131b 100644
>>>> --- a/target-microblaze/cpu.c
>>>> +++ b/target-microblaze/cpu.c
>>>> @@ -1,6 +1,7 @@
>>>>  /*
>>>>  * QEMU MicroBlaze CPU
>>>>  *
>>>> + * Copyright (c) 2009 Edgar E. Iglesias
>>>>  * Copyright (c) 2012 SUSE LINUX Products GmbH
>>>
>>> Trivial nitpick - please add
>>>
>>> Copyright (c) 2009-2012 PetaLogix Qld Pty Ltd
>>>
>>> here as well - we've been driving and funding pretty much all of the
>>> MicroBlaze QEMU development the last 3 years, we should be in the
>>> headers.
>>
>> The reason for splitting the original patches up was to make clearer for
>> reviewers where particular code snippets come from.
>>
>> Could you guys please prepare a patch that updates the copyright in
>> translate.c so that it doesn't come out of the blue here? I'll happily
>> rebase onto that.
> 
> Your patches look ok, can you please rebase on top of the added copyright
> notice and I'll give then a test and commit.

Done. Thanks for your support,

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg