[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/20] w64: Undefine macro SYS_OPEN (fixes a com
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 08/20] w64: Undefine macro SYS_OPEN (fixes a compiler warning) |
Date: |
Sun, 15 Apr 2012 17:00:09 +0000 |
On Sun, Apr 15, 2012 at 14:13, Stefan Weil <address@hidden> wrote:
> This could also be done in arm-semi.c, but doing it here keeps more
> w64 related code in one place.
This is just papering over the bug, it could show up with a different
OS. The right fix is to change arm-semi.c to prefix the #defines with
TARGET_ or QEMU_ so they no longer clash with system definitions.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> qemu-os-win32.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-os-win32.h b/qemu-os-win32.h
> index 753679b..99e8423 100644
> --- a/qemu-os-win32.h
> +++ b/qemu-os-win32.h
> @@ -65,6 +65,10 @@
> # define setjmp(env) _setjmp(env, NULL)
> #endif
>
> +/* MinGW-w64 defines SYS_OPEN in stdio.h,
> + * but arm-semi.c uses a different definition. */
> +#undef SYS_OPEN
> +
> /* Declaration of ffs() is missing in MinGW's strings.h. */
> int ffs(int i);
>
> --
> 1.7.0.4
>
- [Qemu-devel] [PATCH 00/20] w64: Add support for new host, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 01/20] tcg/i386: Use GDB JIT debugging interface only for hosts with ELF, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 02/20] tcg/i386: Add support for w64 ABI, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 03/20] w64: Fix type casts used in some macros in cpu-all.h, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 08/20] w64: Undefine macro SYS_OPEN (fixes a compiler warning), Stefan Weil, 2012/04/15
- Re: [Qemu-devel] [PATCH 08/20] w64: Undefine macro SYS_OPEN (fixes a compiler warning),
Blue Swirl <=
- [Qemu-devel] [PATCH 05/20] w64: Use larger alignment for section with generated code, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 06/20] w32: Move defines for socket specific errors to qemu-os-win32.h, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 09/20] w64: Fix struct CPUTLBEntry, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 13/20] w64: Fix type cast in os_host_main_loop_wait, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 11/20] w64: Use uintptr_t in exec.c, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 14/20] target-mips: Fix type cast for w64 (uintptr_t), Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 16/20] cpu-exec: Remove non-portable type cast and fix format string, Stefan Weil, 2012/04/15
- [Qemu-devel] [PATCH 19/20] w64: Fix time conversion for some versions of MinGW-w64, Stefan Weil, 2012/04/15