qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets
Date: Tue, 17 Apr 2012 07:00:16 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 04/17/2012 02:44 AM, Paolo Bonzini wrote:
Il 17/04/2012 09:33, Peter Maydell ha scritto:
I think the issue is that all of these machines mandate a -kernel option.
  qtest doesn't care if you pass a -kernel but requiring a kernel in order to
test a device sucks especially if you don't possess the toolchain to build
such a kernel.

Just testing a device shouldn't require running a particular
board model either, of course.

qtest isn't so much testing a device.  It is really testing a board with
improved determinism, debuggability and logging.

That said, I think a simpler solution is to set kernel/initrd/dtb to
"/dev/null" if qtest is enabled.

Why not refactor the check to be a QEMUMachine property (requires_kernel). That way the check can be moved common code and that common code can have a single check where it sets the parameters to /dev/null if qtest is enabled.

Regards,

Anthony Liguori


Paolo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]