Re: [Qemu-devel] [PATCH 0/3] switch to seavgabios

[Stefan Weil]

Am 17.04.2012 16:39, schrieb Anthony Liguori:
> On 04/17/2012 09:29 AM, malc wrote:
> > On Tue, 17 Apr 2012, Anthony Liguori wrote:
> >
> > > On 04/17/2012 07:33 AM, malc wrote:
> > > > On Tue, 17 Apr 2012, Gerd Hoffmann wrote:
> > > >
> > > > > On 04/17/12 13:40, malc wrote:
> > > > > > On Tue, 17 Apr 2012, Gerd Hoffmann wrote:
> > > > > >
> > > > > > >     Hi,
> > > > > > >
> > > > > > > This patch series switches the vgabios binaries shipped by qemu 
> > > > > > > from
> > > > > > > the
> > > > > > > lgpl'ed vgabios to the seabios version.
> > > > > > >
> > > > > > > There should be no guest-visible changes (especially no 
> > > > > > > regressions)
> > > > > > > in
> > > > > > > theory.  The only known (and intentional) exception is the vesa 2.0
> > > > > > > protected mode interface which is not implemented by the 
> > > > > > > seavgabios.
> > > > > >
> > > > > > What's the reason for it not being done?
> > > > >
> > > > > In summary: Nontrivial effort for questionable gains.
> > > >
> > > > It worked before, and it should continue to do so. Seabios not 
> > > > having a PM
> > > > interface is a regression.
> > > >
> > > > > First, the lgpl'ed vgabios provides the vesa pmi for the bochs 
> > > > > interface
> > > > > (-vga std) only, for the cirrus it is not available.
> > > >
> > > > Well aware, Revision 1.48 has some comments.
> > > >
> > > > > =>   It can't be a critical feature if our default vga is not 
> > > > > supported.
> > > >
> > > > Opinions are irrelevant, the feature was available before it should
> > > > continue to be available.
> > >
> > > I don't think that's a reasonable position to take.  Do you have a 
> > > specific
> > > workload that uses the pm interface?
> >
> > Yes, but i need to find time and energy to find out which demos use PM
> > window setting.
>
> Okay, it would be very helpful if you could.  I think it's fine to 
> hold off on SeaVGABIOS for 1.1 but it would be nice to get it in for 1.2.

You could also add SeaVGABIOS using to 1.1 while still providing the 
current default vgabios.
Just put the new files in a new subdirectory. Then it's easier for users 
to test the SeaVGABIOS
without the need to pull from Gerd's git repository.

Regards,
Stefan W.