[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set by bus na
From: |
Anthony Liguori |
Subject: |
[Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set by bus name |
Date: |
Wed, 18 Apr 2012 15:56:43 -0500 |
This is technically a compatibility breaker. However:
1) libvirt does not rely on this (it always uses the driver name)
2) This behavior isn't actually documented anywhere (the docs just say driver).
3) I suspect there are less than three people on earth that even know this is
possible (minus the people reading this message).
So I think we can safely break it :-)
Signed-off-by: Anthony Liguori <address@hidden>
---
hw/qdev-properties.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 98dd06a..894fa79 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -1172,8 +1172,7 @@ void qdev_prop_set_globals(DeviceState *dev)
GlobalProperty *prop;
QTAILQ_FOREACH(prop, &global_props, next) {
- if (strcmp(object_get_typename(OBJECT(dev)), prop->driver) != 0 &&
- strcmp(qdev_get_bus_info(dev)->name, prop->driver) != 0) {
+ if (strcmp(object_get_typename(OBJECT(dev)), prop->driver) != 0) {
continue;
}
if (qdev_prop_parse(dev, prop->property, prop->value) != 0) {
--
1.7.5.4
- [Qemu-devel] [PATCH 00/14] qom: convert busses to QOM, Anthony Liguori, 2012/04/18
- [Qemu-devel] [PATCH 01/14] qdev: fix adding of ptr properties, Anthony Liguori, 2012/04/18
- [Qemu-devel] [PATCH 02/14] object: add object_property_foreach, Anthony Liguori, 2012/04/18
- [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties, Anthony Liguori, 2012/04/18
- [Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set by bus name,
Anthony Liguori <=
- [Qemu-devel] [PATCH 05/14] qdev: use wrapper for qdev_get_path, Anthony Liguori, 2012/04/18
- [Qemu-devel] [PATCH 07/14] qdev: fix info qtree/qdm, Anthony Liguori, 2012/04/18
- [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Anthony Liguori, 2012/04/18
- Re: [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Andreas Färber, 2012/04/18
- Re: [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Anthony Liguori, 2012/04/18
- Re: [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Igor Mammedov, 2012/04/19
- Re: [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Andreas Färber, 2012/04/19
- Re: [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Paolo Bonzini, 2012/04/19
- Re: [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Anthony Liguori, 2012/04/19
- Re: [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object, Peter Maydell, 2012/04/19