Re: [Qemu-devel] [PATCH v9 02/10] Add uleb encoding/decoding functions

[Avi Kivity]

On 04/18/2012 08:20 PM, Anthony Liguori wrote:
> On 04/11/2012 01:49 PM, Orit Wasserman wrote:
>> Implement Unsigned Little Endian Base 128.
>>
>> Signed-off-by: Orit Wasserman<address@hidden>
>> ---
>>   migration.h |    4 ++++
>>   savevm.c    |   28 ++++++++++++++++++++++++++++
>>   2 files changed, 32 insertions(+), 0 deletions(-)
>>
>> diff --git a/migration.h b/migration.h
>> index 691b367..d798fac 100644
>> --- a/migration.h
>> +++ b/migration.h
>> @@ -92,4 +92,8 @@ void migrate_add_blocker(Error *reason);
>>    */
>>   void migrate_del_blocker(Error *reason);
>>
>> +/* ULEB128 */
>> +int uleb128_encode_small(uint8_t *out, uint32_t n);
>> +int uleb128_decode_small(const uint8 *in, uint32_t *n);
>
> Please stick this in cutils.h and add documentation for the functions.

These aren't generic, they're limited to 14-bit numbers.

-- 
error compiling committee.c: too many arguments to function