[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support
From: |
Zhi Yong Wu |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support |
Date: |
Thu, 19 Apr 2012 17:00:23 +0800 |
On Thu, Apr 19, 2012 at 4:43 PM, Paolo Bonzini <address@hidden> wrote:
> Il 19/04/2012 10:19, Zhi Yong Wu ha scritto:
>>> >
>>> > 2) The series uses vhost-scsi unconditionally, as far as I can tell. So
>> Perhaps there're some cleanup work to do, but it use vhost-scsi
>> *conditionally*. In virtio_scsi_init(), you can see the code as below:
>> if (s->vhost_scsi) {
>> s->vdev.set_status = virtio_scsi_set_status;
>> }
>> As you have seen, virtio_scsi_set_status will be used to trigger
>> vhost_scsi function.
>
> Ok, I was not sure if that was enough.
>From current testing, it can be used to identify if vhost will be
used. I planed to add one flag.
>
>>> Even if it actually worked, you need to mention what happens if you
>>> configure SCSI devices on the same virtio-scsi driver that uses vhost.
>> OK, i will do this in next version.
>
> You probably need to stop exposing the SCSI bus altogether if vhost is
> chosen.
>
> Paolo
--
Regards,
Zhi Yong Wu
- [Qemu-devel] [PATCH 11/16] vhost-scsi: add -vhost-scsi host device, (continued)
- [Qemu-devel] [PATCH 11/16] vhost-scsi: add -vhost-scsi host device, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 08/16] notifier: add validity check and notify function, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 15/16] vhost-scsi: move some definitions to its header file, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 10/16] virtio-pci: check that event notification worked, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 16/16] vhost-scsi: clear endpoint on stopped, zwu . kernel, 2012/04/18
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Paolo Bonzini, 2012/04/19
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Anthony Liguori, 2012/04/19
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Nicholas A. Bellinger, 2012/04/20
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Paolo Bonzini, 2012/04/20
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Stefan Hajnoczi, 2012/04/20
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Nicholas A. Bellinger, 2012/04/21
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Stefan Hajnoczi, 2012/04/23