[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_addres
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_address reset value to ARMCPU |
Date: |
Fri, 20 Apr 2012 18:18:12 +0100 |
On 20 April 2012 18:01, Andreas Färber <address@hidden> wrote:
> Am 14.04.2012 18:42, schrieb Peter Maydell:
>> @@ -213,14 +207,17 @@ static void highbank_init(ram_addr_t ram_size,
>> }
>>
>> for (n = 0; n < smp_cpus; n++) {
>> + ARMCPU *cpu;
>> env = cpu_init(cpu_model);
>> if (!env) {
>> fprintf(stderr, "Unable to find CPU definition\n");
>> exit(1);
>> }
>> + cpu = arm_env_get_cpu(env);
>
> Ugh, I'd like to avoid this creeping into boards... Would you mind
> applying the updated 1-13 (they should all have some tag of mine now)
> and rebasing this one on a patch that I'll send you shortly, changing
> cpu_arm_init() signature?
Aren't boards going to need arm_env_get_cpu() anyway, since they
need to get at a QOM object to set properties on?
(I'm happy to leave this patch off if it's not fully baked yet.
I'll put 1-13 in a pullreq tomorrow I think.)
-- PMM
- [Qemu-devel] [PATCH v2 00/14] target-arm: Create QOM subclass per CPU implementation, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 09/14] target-arm: Move feature register setup to per-CPU init fns, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_address reset value to ARMCPU, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 10/14] target-arm: Move OMAP cp15_i_{max, min} reset to cpu_state_reset, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 07/14] target-arm: Drop JTAG_ID documentation, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 12/14] target-arm: Drop cpu_reset_model_id(), Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 06/14] target-arm: Move SCTLR reset value setup to per cpu init fns, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 00/14] target-arm: Create QOM subclass per CPU implementation, Peter Maydell, 2012/04/14