[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation |
Date: |
Mon, 23 Apr 2012 08:08:46 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Fri, Apr 20, 2012 at 12:15:36PM -0700, MORITA Kazutaka wrote:
> His patch sets the SD_FLAG_CMD_CACHE flag for writes only when the
> user selects cache=writeback or cache=none. If SD_FLAG_CMD_CACHE is
> not set in the request, Sheepdog servers are forced to flush the cache
> like FUA commands.
Ok, I missed that part and it thus seems ok. What still sems missing
is error handling in case the sheepdog cluster doesn't actually support
the new flag. What happens if cache=none is specified with a cluster
not actually supporting it? Remember that cache=none is the default for
many management frontends to qemu.
- [Qemu-devel] [PATCH v4] sheepdog: implement SD_OP_FLUSH_VDI operation, (continued)
- [Qemu-devel] [PATCH v4] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/03
- [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/03
- Re: [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation, MORITA Kazutaka, 2012/04/03
- Re: [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation, Kevin Wolf, 2012/04/03
- [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/03
- Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation, Kevin Wolf, 2012/04/04
- Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/04
- Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation, Kevin Wolf, 2012/04/04
Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation, Christoph Hellwig, 2012/04/20