[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option |
Date: |
Tue, 24 Apr 2012 12:55:15 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Tue, 24 Apr 2012, Kevin Wolf wrote:
> Am 24.04.2012 13:22, schrieb Stefano Stabellini:
> > Use the BDRV_O_CACHE_* flags instead.
> >
> > Signed-off-by: Stefano Stabellini <address@hidden>
>
> Doesn't apply to qemu.git because...
>
> > ---
> > hw/xen_disk.c | 8 +-------
> > 1 files changed, 1 insertions(+), 7 deletions(-)
> >
> > diff --git a/hw/xen_disk.c b/hw/xen_disk.c
> > index 4a6d89c..3e4a47b 100644
> > --- a/hw/xen_disk.c
> > +++ b/hw/xen_disk.c
> > @@ -48,7 +48,6 @@
> >
> > /* ------------------------------------------------------------- */
> >
> > -static int syncwrite = 0;
> > static int batch_maps = 0;
> >
> > static int max_requests = 32;
> > @@ -189,15 +188,10 @@ static int ioreq_parse(struct ioreq *ioreq)
> > ioreq->presync = 1;
> > return 0;
> > }
> > - if (!syncwrite) {
> > - ioreq->postsync = 1;
>
> ...this is ioreq->presync = ioreq->postsync = 1;
That's because it is based on top of the following two patches:
xen_disk: use bdrv_aio_flush instead of bdrv_flush
http://marc.info/?l=qemu-devel&m=133434258008959&w=2
xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER
http://marc.info/?l=qemu-devel&m=133459581417878&w=2
I have just sent a pull request for them
(http://marc.info/?l=qemu-devel&m=133526669019403) after leaving lying
around for a while.
Next time do you want me to send xen_disk specific pull request to you
instead? Sorry if I shouldn't have sent the pull request directly...
> And while we're at it, the commit message could mention that there was
> no way to set this flag anyway, so we're just removing dead code.
good point