[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 03/15] target-i386: Add range check for -cpu , fa
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH v3 03/15] target-i386: Add range check for -cpu , family=x |
Date: |
Wed, 25 Apr 2012 11:23:24 +0200 |
A family field value of 0xf and extended family field value of 0xff is
the maximum representable unsigned family number.
All other CPUID property values are bounds-checked, so add a check here
for symmetry before we adopt it in a property setter.
Signed-off-by: Andreas Färber <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
---
target-i386/cpu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 3dc0f80..5cebb3d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -691,7 +691,7 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def,
const char *cpu_model)
if (!strcmp(featurestr, "family")) {
char *err;
numvalue = strtoul(val, &err, 0);
- if (!*val || *err) {
+ if (!*val || *err || numvalue > 0xff + 0xf) {
fprintf(stderr, "bad numerical value %s\n", val);
goto error;
}
--
1.7.7
- [Qemu-devel] [PATCH v3 09/15] target-i386: Add property getter for CPU model, (continued)
- [Qemu-devel] [PATCH v3 09/15] target-i386: Add property getter for CPU model, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 01/15] target-i386: Fix x86_cpuid_set_model_id(), Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 10/15] target-i386: Add property getter for CPU stepping, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 04/15] target-i386: Add "family" property to X86CPU, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 15/15] target-i386: Introduce "tsc-frequency" property for X86CPU, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 02/15] target-i386: Pass X86CPU to cpu_x86_register(), Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 08/15] target-i386: Add property getter for CPU family, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 13/15] target-i386: Introduce "xlevel" property for X86CPU, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 06/15] target-i386: Add "stepping" property to X86CPU, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 12/15] target-i386: Introduce "level" property for X86CPU, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 03/15] target-i386: Add range check for -cpu , family=x,
Andreas Färber <=
- [Qemu-devel] [PATCH v3 11/15] target-i386: Add property getter for CPU model-id, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 07/15] target-i386: Add "model-id" property to X86CPU, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 14/15] target-i386: Prepare "vendor" property for X86CPU, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v3 05/15] target-i386: Add "model" property to X86CPU, Andreas Färber, 2012/04/25