[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] nbd: Fix uninitialised use of s->sock
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH] nbd: Fix uninitialised use of s->sock |
Date: |
Thu, 26 Apr 2012 13:45:30 +0200 |
s->sock is assigned only afterwards, so we're really registering an
aio_fd_handler for file descriptor 0 here. Not exactly what we intended.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/nbd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 56dbf6e..1212614 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -284,7 +284,7 @@ static int nbd_establish_connection(BlockDriverState *bs)
/* Now that we're connected, set the socket to be non-blocking and
* kick the reply mechanism. */
socket_set_nonblock(sock);
- qemu_aio_set_fd_handler(s->sock, nbd_reply_ready, NULL,
+ qemu_aio_set_fd_handler(sock, nbd_reply_ready, NULL,
nbd_have_request, s);
s->sock = sock;
--
1.7.6.5
- [Qemu-devel] [PATCH] nbd: Fix uninitialised use of s->sock,
Kevin Wolf <=