[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMac
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine |
|
Date: |
Thu, 26 Apr 2012 18:11:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120328 Thunderbird/11.0.1 |
Am 26.04.2012 17:48, schrieb Anthony Liguori:
> On 04/26/2012 10:23 AM, Christian Borntraeger wrote:
>> From: Einar Lueck<address@hidden>
>>
>> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
>> default/standard interface to their block devices / drives. Therefore,
>> this patch introduces a new field def_blk_if per QEMUMachine struct.
>> The prior use_scsi field becomes thereby obsolete and is replaced through
>> .def_blk_if = IF_SCSI.
>
> I'd prefer a less cryptic name along with a reasonable default. If 0
> isn't the right thing for IF_*, we could use another enum.
>
> Looking briefly, it seems like both IF_SCSI and IF_IDE could be a
> reasonable default.
Not so long ago you told me that the whole machine should go into
configuration files... If we do start drilling up QEMUMachine now, we
should seriously QOM'ify it for 1.2.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine, Peter Maydell, 2012/04/26
Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine, Igor Mitsyanko, 2012/04/26