|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()/strtoull() |
Date: | Fri, 27 Apr 2012 15:23:56 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Eric Blake <address@hidden> writes: > On 04/27/2012 03:04 AM, Markus Armbruster wrote: >> Luiz Capitulino <address@hidden> writes: [...] >> You silently interpret a string that doesn't parse as zero. > > No... > >>> + if (n == ULONG_MAX && errno == ERANGE) { >>> + expr_error(mon, "number too large"); >>> + } >>> #endif >>> if (pch == p) { >>> expr_error(mon, "invalid char in expression"); > > that check was already present. You mean I'm supposed to read patch context?
[Prev in Thread] | Current Thread | [Next in Thread] |