Re: [Qemu-devel] [PATCH] sdl: Avoid unnecessary resizing of the display surface

[Paolo Bonzini]

Il 01/05/2012 07:53, Stefan Weil ha scritto:
> If neither width nor height changes, nothing has to be done.
> 
> Cc: Anthony Liguori <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> 
> This patch improves SDL for any host (for example with remote X displays),
> but the main reason why I wrote it was another problem:
> 
> On w32 / w64 hosts, qemu-system-arm has a deadlock when it calls
> sdl_resize_displaysurface during Linux boot. One thread waits for
> a critical region, another thread waits inside SDL_SetVideoMode.
> 
> The patch avoids this problem. Paolo, maybe you have an idea what
> could cause the deadlock.

No idea---honestly, my w32 interest is limited to replacing hacks with
proper solutions. :)  It turns out that in many cases you can fix bugs
along the way and that helps having people look at your patches...

Paolo