[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass |
Date: |
Tue, 01 May 2012 21:34:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 01.05.2012 20:18, schrieb Anthony Liguori:
> It should have never been a bus method.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
[...]
> diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
> index 4a468f8..5044018 100644
> --- a/hw/ide/qdev.c
> +++ b/hw/ide/qdev.c
> @@ -25,22 +25,13 @@
>
> /* --------------------------------- */
>
> -static char *idebus_get_fw_dev_path(DeviceState *dev);
> -
> #define TYPE_IDE_BUS "IDE"
> -
> -static void ide_bus_class_init(ObjectClass *klass, void *data)
> -{
> - BusClass *k = BUS_CLASS(klass);
> -
> - k->get_fw_dev_path = idebus_get_fw_dev_path;
> -}
> +#define IDE_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS)
Move macro to preceding patch?
Otherwise looks good.
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 07/14] qdev: fix info qtree/qdm, (continued)
- [Qemu-devel] [PATCH 07/14] qdev: fix info qtree/qdm, Anthony Liguori, 2012/05/01
- [Qemu-devel] [PATCH 12/14] qbus: move print_dev to DeviceClass, Anthony Liguori, 2012/05/01
- [Qemu-devel] [PATCH 13/14] qbus: make child devices links, Anthony Liguori, 2012/05/01
- [Qemu-devel] [PATCH 01/14] qdev: fix adding of ptr properties, Anthony Liguori, 2012/05/01
- [Qemu-devel] [PATCH 09/14] qdev: connect some links and move type to object (v2), Anthony Liguori, 2012/05/01
- [Qemu-devel] [PATCH 06/14] qdev: move properties from businfo to base class instance init, Anthony Liguori, 2012/05/01
- [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass, Anthony Liguori, 2012/05/01
- Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass,
Andreas Färber <=
[Qemu-devel] [PATCH 08/14] qdev: convert busses to QEMU Object Model, Anthony Liguori, 2012/05/01
[Qemu-devel] [PATCH 10/14] qbus: move get_dev_path to DeviceState, Anthony Liguori, 2012/05/01