[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set by bu
Re: [Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set by bus name
Tue, 01 May 2012 23:47:22 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120425 Thunderbird/12.0
Il 01/05/2012 22:46, Anthony Liguori ha scritto:
>>> So I think we can safely break it :-)
>> Does this work with compat properties set on a bus?
> No :-(
> This is pretty easy to fix though. The attached should do the trick,
> I'll update and send out.
> Even if it does,
>> perhaps it's better to avoid the cleverness and wait for my series that
>> moves bus properties to the appropriate abstract superclass.
> This series does that FWIW (patch 6/14).
Yeah, it should---modulo bisectability of course.
It's a fairly different approach WRT my series (using
qdev_add_properties instead of klass->props). In theory I like it, but
I fail to see right now whether it breaks "-device foo,?" somehow. I
think it does:
$ qemu-system-x86_64 -device rtl8139,?
rtl8139.addr=pci-devfn <<< here start bus props
I think it's too late for this series to go into 1.1.
[Qemu-devel] [PATCH 02/14] object: add object_property_foreach, Anthony Liguori, 2012/05/01
[Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties, Anthony Liguori, 2012/05/01