[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390 |
Date: |
Thu, 03 May 2012 05:16:50 -0400 (EDT) |
> > Uhm, Christian fix would have the same problem actually if
> > virtio-*-pci were to be moved in libhw. IIRC I proposed the
> > same change on review and Anthony nacked it on these grounds.
> > You could move the alias list to target-dependent code, though.
>
> Can't we just make the virtio-*-pci variants fail instantiation and
> based on that search the list on?
The alias list is used in other places than just instantiation
(e.g. -device ?). If it were me I'd just go with Christian's patch;
it is conceptually broken, but in the same way as QEMU 1.0 (i.e.
relies on virtio-*-pci not being compiled into s390 binaries). A
comment will do.
Paolo
- [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Christian Borntraeger, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Christian Borntraeger, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Paolo Bonzini, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Paolo Bonzini, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Anthony Liguori, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/17
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Anthony Liguori, 2012/05/17