qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit
Date: Thu, 03 May 2012 17:02:51 -0300
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2012-05-03 16:32, malc wrote:
> On Thu, 3 May 2012, Jan Kiszka wrote:
> 
>> Not only clean up enabled voices but any registered one. Backends like
>> pulsaudio rely on unconditional fini handler invocations.
>>
>> This fixes "Memory pool destroyed but not all memory blocks freed!"
>> warnings on VM shutdowns when pa is used.
> 
> Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]?

This might be some additional issue (that pa is not supporting
enable/disable). In any case, it is unrelated to this one: fini
corresponds to init. And as we initialized the voice, we also have to
finalize it on shutdown. That's what this patch is fixing.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]