[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatt

From: Peter Maydell
Subject: Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)
Date: Fri, 4 May 2012 11:04:52 +0100

On 4 May 2012 01:41, Anthony Liguori <address@hidden> wrote:
> On 05/03/2012 02:58 PM, Peter Maydell wrote:
>> No unreviewed patches should go double when we're in hardfreeze!
> These patches are admittedly trivial but it is important to stress the point
> that all patches need to go on the mailing list before being committed.
> It's an important part of keeping the development process inclusive.  I
> don't think it's reasonable to ask for an Acked-by on something as simple as
> indentation changes but at the same time, there's no reason not to just post
> patches.

Yes, it is specifically the failure to follow the standard process
of posting patches and allowing the opportunity for review before commit
that I'm complaining about. Obviously if nobody cares to actually do
the review that's their lookout.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]