|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH 06/14] scsi: change "removable" field to host many features |
Date: | Fri, 04 May 2012 18:30:24 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 |
Am 04.05.2012 10:45, schrieb Paolo Bonzini:
It is pointless to add a uint32_t field for every new feature. Since we will need a new feature soon, convert accesses to "removable" to look at bit 0 only. Signed-off-by: Paolo Bonzini<address@hidden> --- hw/scsi-disk.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index fbb1041..e04b469 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -61,10 +61,12 @@ typedef struct SCSIDiskReq { BlockAcctCookie acct; } SCSIDiskReq; +#define SCSI_DISK_F_REMOVABLE 0 +
ERROR: code indent should never use tabs #23: FILE: hw/scsi-disk.c:64: +#define SCSI_DISK_F_REMOVABLE^I0$ total: 1 errors, 0 warnings, 74 lines checked0006-scsi-change-removable-field-to-host-many-features.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
[Prev in Thread] | Current Thread | [Next in Thread] |