[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qcow2: Unlock during COW
From: |
Zhi Yong Wu |
Subject: |
Re: [Qemu-devel] [PATCH v2] qcow2: Unlock during COW |
Date: |
Sat, 5 May 2012 11:17:16 +0800 |
On Sat, May 5, 2012 at 8:21 AM, Marc-André Lureau
<address@hidden> wrote:
> Hi
>
> On Mon, Nov 14, 2011 at 6:55 PM, Kevin Wolf <address@hidden> wrote:
>> Unlocking during COW allows for more parallelism. One change it requires is
>> that buffers are dynamically allocated instead of just using a per-image
>> buffer.
>
> This commit introduces failure with preallocation and some sizes:
>
> qemu-img create -f qcow2 new.img 976563K -o preallocation=metadata
> qemu-img: qemu-coroutine-lock.c:111: qemu_co_mutex_unlock: Assertion
> `mutex->locked == 1' failed.
For this issue, i have submitted two patches, can you help test agaist
my patchs?
1. [1/2] block: make bdrv_create adopt coroutine
http://patchwork.ozlabs.org/patch/157022/
2. [2/2] qcow2: lock on prealloc
http://patchwork.ozlabs.org/patch/157023/
>
> regards
>
> --
> Marc-André Lureau
>
--
Regards,
Zhi Yong Wu